Security Guidance for ASP.NET Web API 2 OData
by Mike Wasson
This topic describes some of the security issues that you should consider when exposing a dataset through OData.
EDM Security
The query semantics are based on the entity data model (EDM), not the underlying model types. You can exclude a property from the EDM and it will not be visible to the query. For example, suppose your model includes an Employee type with a Salary property. You might want to exclude this property from the EDM to hide it from clients.
There are two ways to exlude a property from the EDM. You can set the [IgnoreDataMember] attribute on the property in the model class:
[!code-csharpMain]
1: public class Employee
2: {
3: public string Name { get; set; }
4: public string Title { get; set; }
5: [IgnoreDataMember]
6: public decimal Salary { get; set; } // Not visible in the EDM
7: }
You can also remove the property from the EDM programmatically:
[!code-csharpMain]
1: var employees = modelBuilder.EntitySet<Employee>("Employees");
2: employees.EntityType.Ignore(emp => emp.Salary);
Query Security
A malicious or naive client may be able to construct a query that takes a very long time to execute. In the worst case this can disrupt access to your service.
The [Queryable] attribute is an action filter that parses, validates, and applies the query. The filter converts the query options into a LINQ expression. When the OData controller returns an IQueryable type, the IQueryable LINQ provider converts the LINQ expression into a query. Therefore, performance depends on the LINQ provider that is used, and also on the particular characteristics of your dataset or database schema.
For more information about using OData query options in ASP.NET Web API, see Supporting OData Query Options.
If you know that all clients are trusted (for example, in an enterprise environment), or if your dataset is small, query performance might not be an issue. Otherwise, you should consider the following recommendations.
- Test your service with various queries and profile the DB.
Enable server-driven paging, to avoid returning a large data set in one query. For more information, see Server-Driven Paging.
[!code-csharpMain]1: // Enable server-driven paging.
2: [Queryable(PageSize=10)]Do you need $filter and $orderby? Some applications might allow client paging, using $top and $skip, but disable the other query options.
[!code-csharpMain]1: // Allow client paging but no other query options.
2: [Queryable(AllowedQueryOptions=AllowedQueryOptions.Skip |3: AllowedQueryOptions.Top)]Consider restricting $orderby to properties in a clustered index. Sorting large data without a clustered index is slow.
[!code-csharpMain]1: // Set the allowed $orderby properties.
2: [Queryable(AllowedOrderByProperties="Id,Name")] // Comma separated list
Maximum node count: The MaxNodeCount property on [Queryable] sets the maximum number nodes allowed in the $filter syntax tree. The default value is 100, but you may want to set a lower value, because a large number of nodes can be slow to compile. This is particularly true if you are using LINQ to Objects (i.e., LINQ queries on a collection in memory, without the use of an intermediate LINQ provider).
[!code-csharpMain]1: // Set the maximum node count.
2: [Queryable(MaxNodeCount=20)]Consider disabling the any() and all() functions, as these can be slow.
[!code-csharpMain]1: // Disable any() and all() functions.
2: [Queryable(AllowedFunctions= AllowedFunctions.AllFunctions &3: ~AllowedFunctions.All & ~AllowedFunctions.Any)]If any string properties contain large strings—for example, a product description or a blog entry—consider disabling the string functions.
[!code-csharpMain]1: // Disable string functions.
2: [Queryable(AllowedFunctions=AllowedFunctions.AllFunctions &3: ~AllowedFunctions.AllStringFunctions)]Consider disallowing filtering on navigation properties. Filtering on navigation properties can result in a join, which might be slow, depending on your database schema. The following code shows a query validator that prevents filtering on navigation properties. For more information about query validators, see Query Validation.
[!code-csharpMain]1: // Validator to prevent filtering on navigation properties.
2: public class MyFilterQueryValidator : FilterQueryValidator
3: {4: public override void ValidateNavigationPropertyNode(
5: Microsoft.Data.OData.Query.SemanticAst.QueryNode sourceNode,6: Microsoft.Data.Edm.IEdmNavigationProperty navigationProperty,7: ODataValidationSettings settings)8: {9: throw new ODataException("No navigation properties");
10: }11: }Consider restricting $filter queries by writing a validator that is customized for your database. For example, consider these two queries:
- All movies with actors whose last name starts with ???A???.
- All movies released in 1994.
Unless movies are indexed by actors, the first query might require the DB engine to scan the entire list of movies. Whereas the second query might be acceptable, assuming movies are indexed by release year.
The following code shows a validator that allows filtering on the ???ReleaseYear??? and ???Title??? properties but no other properties.
[!code-csharpMain]1: // Validator to restrict which properties can be used in $filter expressions.
2: public class MyFilterQueryValidator : FilterQueryValidator
3: {4: static readonly string[] allowedProperties = { "ReleaseYear", "Title" };
5:6: public override void ValidateSingleValuePropertyAccessNode(
7: SingleValuePropertyAccessNode propertyAccessNode,8: ODataValidationSettings settings)9: {10: string propertyName = null;
11: if (propertyAccessNode != null)
12: {13: propertyName = propertyAccessNode.Property.Name;14: }15:16: if (propertyName != null && !allowedProperties.Contains(propertyName))
17: {18: throw new ODataException(
19: String.Format("Filter on {0} not allowed", propertyName));
20: }21: base.ValidateSingleValuePropertyAccessNode(propertyAccessNode, settings);
22: }23: }In general, consider which $filter functions you need. If your clients do not need the full expressiveness of $filter, you can limit the allowed functions.
)
|
|